-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use plugin description in search command #26
Comments
Yeah, we are currently not using the description for the search. We are only searching plugin names. |
@orthros is taking a stab at this. |
If its still free, i would like to take a look at this @ahmetb |
@nammn Feel free to work on a patch. |
great, i'll work on this patch 👍 |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Any update on this one? The new virt plugin is also affected by this (not found if searched for kubevirt). |
/remove-lifecycle rotten We'll probably get to it at some point. It's not a super high priority since most users probably find plugins through some github repo so they know its installation command. |
Ok. Would you be open to a PR?
|
We already had #150 but happy to give it another try. This might require some experimentation. Text search isn't a simple problem, and we might need to sanitize the input a little bit (e.g. to remove line breaks, figure out how to treat urls in descriptions and so on). |
The same applies to the Did you consider adding the name: "who-can"
keywords: ["rbac", "authorization"] |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
I'm unsure what to do with this issue. On the one hand #150 was closed long ago, but a search in |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubectl plugin search certificate
is not bringing up ca-cert which has the word in its description./priority P2
/priority backlog
The text was updated successfully, but these errors were encountered: