-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error from server (Invalid): error when applying patch: Job.batch "migration-elasticsearch" is invalid: #3171
Comments
I just experienced a similar error when deploying a |
Here is a repo with command output in README and source files to demonstrate the bug. This works in v0.40.0 but not in v0.41.0. |
Not sure if related but I've encountered an issue with |
Hi @tejal29 , This is not a feature request. This is actually a bug. I tested the same code with v0.40.0 it works fine but v0.41.0 breaks it. I didn't try it with v1.0.0 yet. |
I can confirm this error still exists in version v1.0.0 |
@balopat any chance you can promote the fix to this bug? |
hey all, sorry for the delay on this one. I was able to reproduce with the repo that @chinmaya-n provided (thank you!), and it looks like this was broken by #3086. we'll need to add back force applying to make this work again for jobs. |
Can confirm this issue persists on v1.1.0 |
Let me try to summarise my understanding because I'm not sure I've it all right:
@giladsh1 @lienharc @doman412 @chinmaya-n Can you confirm that running skaffold with |
@dgageot I can confirm that adding the |
Good! Now we need to define sensible defaults. |
IMHO adding force by default doesn't make sense for commands other than The question is why does it seldom break the deployment for cronjobs only? |
I'm seeing this happen with deployments too on v1.3.1 |
@dgageot I can confirm the the force flag fixes this for me with |
Looks like from last comment, this issue is fixed on v1.3.1. |
I don't think this is fixed. If I don't use force, I get an error:
because the newly issued |
I believe the underlying issue on this ticket is that
And updating labels on an existing k8s Deployment is not allowed (kubernetes/kubernetes#26202). If you successfully deployed your Deployment with You can work around the issue using You could also presumably use #2752 to override the kustomize client version too, something like
However this seems like a suboptimal workaround. |
There is a lot going on in this issue - so if folks are still running into problems similar to this, please open a new issue containing a reproduction case and logs from the latest version of skaffold. Thank you for sharing your experience! |
Information
Skaffold latest version fails to apply a job.
The previous version (v0.40.0) works with no issue.
When deploying to GKE (v1.13.11-gke.5), I get the following error -
Steps to reproduce the behavior
skaffold run -l skaffold.dev/run-id=com -p com-test -v debug
The text was updated successfully, but these errors were encountered: