Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a function or add a flag for IDEs to get a finalized image name with prepended default image repository without actually building and pushing #3546

Closed
ivanporty opened this issue Jan 21, 2020 · 2 comments · Fixed by #4039
Assignees
Labels
area/default-repo ide kind/design discussion kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@ivanporty
Copy link
Contributor

A user only sees the finalized image name (default image repository + converted image name from manifests) once deployment or build starts. IDEs could show the expected image name in the run configurations to make it easier to decide if that's what a user needs and understand errors better if it doesn't work.

We can use some flag to get an expected image (given default image repo), or use dry run of build to get it.

@balopat balopat added kind/feature-request ide priority/p3 agreed that this would be good to have, but no one is available at the moment. area/default-repo kind/design discussion labels Jan 21, 2020
@dgageot dgageot self-assigned this Apr 22, 2020
@tstromberg
Copy link
Contributor

@dgageot - what did you have in mind as far as fixing this?

It initially sounded like a good use of a --dry-run flag, but I wonder if you had something more targeted in mind.

@dgageot
Copy link
Contributor

dgageot commented Apr 24, 2020 via email

dgageot added a commit to dgageot/skaffold that referenced this issue Apr 28, 2020
Fixes GoogleContainerTools#3546

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Apr 28, 2020
Fixes GoogleContainerTools#3546

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit that referenced this issue Apr 28, 2020
Fixes #3546

Signed-off-by: David Gageot <david@gageot.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/default-repo ide kind/design discussion kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants