Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev should not error out on introduced error to skaffold.yaml #4225

Open
briandealwis opened this issue May 19, 2020 · 0 comments
Open

dev should not error out on introduced error to skaffold.yaml #4225

briandealwis opened this issue May 19, 2020 · 0 comments
Labels
area/cli area/dev kind/feature-request priority/p2 May take a couple of releases

Comments

@briandealwis
Copy link
Member

Follow-on to #4158: skaffold dev shouldn't error out on a typo to skaffold.yaml. I made a mistake while uncommenting and forgot to uncomment a line to produce an invalid yaml:

Pruning images...
WARN[0217] builder cleanup: pruning images: could not remove image after 5 retries 
parsing skaffold config: unable to parse config: yaml: unmarshal errors:
  line 7: cannot unmarshal !!seq into v2beta3.KubectlDeploy

and Skaffold then exited.
dgageot added a commit to dgageot/skaffold that referenced this issue Jul 31, 2020
@dgageot
Make the dev loop interruptible.
800ab37 
Wether it’s during the build, the deploy or the
status check, the dev loop can now be interrupted
on a file change.

Fix GoogleContainerTools#3908
Fix GoogleContainerTools#916

If it’s the skaffold.yaml that’s modified, instead
Of restarting the dev loop right away, we first
validate that the config is valid.

Fix GoogleContainerTools#4225

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot mentioned this issue Jul 31, 2020
Closed
dgageot added a commit to dgageot/skaffold that referenced this issue Jul 31, 2020
@dgageot
Make the dev loop interruptible.
3598485 
Wether it’s during the build, the deploy or the
status check, the dev loop can now be interrupted
on a file change.

Fix GoogleContainerTools#3908
Fix GoogleContainerTools#916

If it’s the skaffold.yaml that’s modified, instead
Of restarting the dev loop right away, we first
validate that the config is valid.

Fix GoogleContainerTools#4225

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jul 31, 2020
@dgageot
Make the dev loop interruptible.
6e5f1b0 
Wether it’s during the build, the deploy or the
status check, the dev loop can now be interrupted
on a file change.

Fix GoogleContainerTools#3908
Fix GoogleContainerTools#916

If it’s the skaffold.yaml that’s modified, instead
Of restarting the dev loop right away, we first
validate that the config is valid.

Fix GoogleContainerTools#4225

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jul 31, 2020
@dgageot
Make the dev loop interruptible.
10cd38e 
Wether it’s during the build, the deploy or the
status check, the dev loop can now be interrupted
on a file change.

Fix GoogleContainerTools#3908
Fix GoogleContainerTools#916

If it’s the skaffold.yaml that’s modified, instead
Of restarting the dev loop right away, we first
validate that the config is valid.

Fix GoogleContainerTools#4225

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jul 31, 2020
@dgageot
Make the dev loop interruptible.
12720ed 
Wether it’s during the build, the deploy or the
status check, the dev loop can now be interrupted
on a file change.

Fix GoogleContainerTools#3908
Fix GoogleContainerTools#916

If it’s the skaffold.yaml that’s modified, instead
Of restarting the dev loop right away, we first
validate that the config is valid.

Fix GoogleContainerTools#4225

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Aug 1, 2020
@dgageot
Make the dev loop interruptible.
1527a15 
Wether it’s during the build, the deploy or the
status check, the dev loop can now be interrupted
on a file change.

Fix GoogleContainerTools#3908
Fix GoogleContainerTools#916

If it’s the skaffold.yaml that’s modified, instead
Of restarting the dev loop right away, we first
validate that the config is valid.

Fix GoogleContainerTools#4225

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Aug 16, 2020
@dgageot
Make the dev loop interruptible.
80a73e3 
Wether it’s during the build, the deploy or the
status check, the dev loop can now be interrupted
on a file change.

Fix GoogleContainerTools#3908
Fix GoogleContainerTools#916

If it’s the skaffold.yaml that’s modified, instead
Of restarting the dev loop right away, we first
validate that the config is valid.

Fix GoogleContainerTools#4225

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Aug 31, 2020
@dgageot
Make the dev loop interruptible.
c1708b4 
Wether it’s during the build, the deploy or the
status check, the dev loop can now be interrupted
on a file change.

Fix GoogleContainerTools#3908
Fix GoogleContainerTools#916

If it’s the skaffold.yaml that’s modified, instead
Of restarting the dev loop right away, we first
validate that the config is valid.

Fix GoogleContainerTools#4225

Signed-off-by: David Gageot <david@gageot.net>
@nkubala nkubala added this to the Icebox [P2+] milestone Sep 1, 2020
@nkubala nkubala removed this from the Icebox [P2+] milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cli area/dev kind/feature-request priority/p2 May take a couple of releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the dev loop interruptible. dgageot/skaffold
2 participants
@briandealwis @nkubala