Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functionality not covered by integration tests #441

Closed
12 of 13 tasks
r2d4 opened this issue Apr 23, 2018 · 1 comment
Closed
12 of 13 tasks

Functionality not covered by integration tests #441

r2d4 opened this issue Apr 23, 2018 · 1 comment
Assignees
@dgageot
Labels
help wanted We would love to have this done, but don't have the bandwidth, need help from contributors meta/release meta/testing Issues focused on testing Skaffold itself priority/p0 Highest priority. We are actively looking at delivering it.

Comments

@r2d4
Copy link
Contributor

r2d4 commented Apr 23, 2018 •
edited by dgageot

An umbrella issue with the functionality not covered by integration tests. These items should be verified manually.

Examples not covered by integration tests

  • ./skaffold.yaml
  • examples/kaniko
  • examples/bazel
  • examples/helm
  • examples/microservices
  • examples/jib
  • examples/nodejs
  • examples/structure-tests

Commands not covered by integration tests

  • skaffold dev
  • skaffold build
  • skaffold deploy
  • skaffold delete
  • skaffold completion
@r2d4 r2d4 added area/testing Issues concerning the testing phase of Skaffold meta/release labels Apr 23, 2018
@r2d4 r2d4 added the priority/p0 Highest priority. We are actively looking at delivering it. label Jun 6, 2018
This was referenced Jun 6, 2018
Closed
Closed
Closed
@r2d4 r2d4 added the help wanted We would love to have this done, but don't have the bandwidth, need help from contributors label Jun 6, 2018
@dlorenc dlorenc mentioned this issue Jun 25, 2018
Merged
@r2d4 r2d4 mentioned this issue Aug 6, 2018
Merged
@priyawadhwa priyawadhwa mentioned this issue Aug 31, 2018
Merged
@nkubala nkubala added meta/testing Issues focused on testing Skaffold itself and removed area/testing Issues concerning the testing phase of Skaffold labels Sep 18, 2018
@dgageot dgageot self-assigned this Jan 21, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Feb 8, 2019
@dgageot
Adding a few tests for skaffold build
cd6da7b 
See GoogleContainerTools#441

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot mentioned this issue Feb 8, 2019
Merged
dgageot added a commit to dgageot/skaffold that referenced this issue Feb 8, 2019
@dgageot
Adding a few tests for skaffold build
38a2905 
See GoogleContainerTools#441

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Feb 8, 2019
@dgageot
Adding a few tests for skaffold build
397cc60 
See GoogleContainerTools#441

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Feb 8, 2019
@dgageot
Adding a few tests for skaffold build
74496ec 
See GoogleContainerTools#441

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Feb 8, 2019
@dgageot
Adding a few tests for skaffold build
49fa1af 
See GoogleContainerTools#441

Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Copy link
Contributor

dgageot commented Mar 22, 2019

I'm going to close this one because all of them are covered (except skaffold completion that I'll cover with unit tests)

@dgageot dgageot closed this as completed Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgageot dgageot

Labels
help wanted We would love to have this done, but don't have the bandwidth, need help from contributors meta/release meta/testing Issues focused on testing Skaffold itself priority/p0 Highest priority. We are actively looking at delivering it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dgageot @r2d4 @nkubala