Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract separate Helm binVer tests #4714

Closed
briandealwis opened this issue Aug 24, 2020 · 0 comments · Fixed by #4715
Closed

Extract separate Helm binVer tests #4714

briandealwis opened this issue Aug 24, 2020 · 0 comments · Fixed by #4715
Labels
deploy/helm fixit meta/testing Issues focused on testing Skaffold itself

Comments

@briandealwis
Copy link
Member

The Helm deployer tests implicitly perform version-parsing in TestHelmDeploy(). This should be broken out into a separate test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deploy/helm fixit meta/testing Issues focused on testing Skaffold itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add explicit tests for Helm version parsing briandealwis/skaffold
1 participant
@briandealwis