Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit tests for Helm version parsing #4715

Merged
merged 1 commit into from Aug 25, 2020

Conversation

briandealwis
Copy link
Member

Fixes: #4714

Avoid cluttering TestHelmDeploy with version tests.

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #4715 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4715   +/-   ##
=======================================
  Coverage   73.38%   73.38%           
=======================================
  Files         341      341           
  Lines       13505    13505           
=======================================
  Hits         9910     9910           
  Misses       2976     2976           
  Partials      619      619           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bad4b31...4cbc1a0. Read the comment docs.

@briandealwis briandealwis merged commit 6d9e671 into GoogleContainerTools:master Aug 25, 2020
@briandealwis briandealwis deleted the i4714 branch August 25, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract separate Helm binVer tests
3 participants