skaffold build should support a --push flag to override build.local.push

[briandealwis]

The container-debug-support images uses skaffold build to build and test images. These builds don't have a cluster available and so a plain skaffold build causes Skaffold to attempt to build and push images, which fails. So we explicitly configure build.local.push: false so that the images are only built to the local Docker daemon.

[tejal29]

Discussion notes:

1. skaffold build should not run tests
2. skaffold test with --build-artifacts not run build.
   • Current behavior: skaffold test should run build only if no --build-artifacts is present
3. Adding a command a line skaffold build --push and respect --push.

[aaron-prindle]

To clarify how the --push flag should work, does this mean that skaffold build now defaults to not pushing images w/o the --push flag (and also no config set)? Or does it just have precendence over the config setting - build.local.push: false w/ no changes to the default?

[gsquared94]

Right now, if build.local.push is explicitly set then it uses that value, otherwise it tries to infer:

• If the cluster is minikube (we run minikube profile command, check a few heuristics), don't push
• If the cluster is kind or k3d, don't push; unless the cluster-image-load ( a global config property) is also disabled, in which case push
• For all other clusters push

This approach does however have the unintuitive behavior of checking kube-context and cluster details (like minikube docker-env, etc.) even when the intention is to only build.

[gsquared94]

From OP's sentiment, I think they want to be able to say skaffold build --push=false and override whatever is set in the skaffold.yaml file.