-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs fixit] Rename Skaffold API
to Skaffold gRPC and HTTP service
#6479
Comments
I am not sure if people would confuse the skaffold.yaml which is a config file with the API. The "Skaffold API" term IMO more clearly explains the feature than "Skaffold [...] service". I am currently -1 on this. 👎🏼 |
for tilt.dev, "Tiltfile API" is used for the config file schema link. They don't seem to have any Skaffold API equivalent atm. In Skaffold the link for the config file schema is called "Skaffold Pipeline": No data to support this, but I'd click @ahmetb how about wdyt @kourtneyshort ? |
If the Skaffold Meta API would be clearer to customers, that sounds good to me. In https://skaffold.dev/docs/references/api/, you link to the other page but I don't think the sentence makes clear that the link is taking them to a different thing. "For a detailed description of the Skaffold API. So on https://skaffold.dev/docs/references/api/, I'd suggest: Naming the page something more informative than API This section describes the (refer to the API by the same name you give the page) that lets you retreive information about the state of the process and exert fine-grained control over its execution. If you're looking for the config file schema, see the Skaffold API (or whatever the new page title is). You could also consider adding something here https://skaffold.dev/docs/design/api/ in case someone ends up there in error and should go to the other API |
Agreed, I added a similar warning #6503. Happy to take on to fix it that way. I don't think we need to follow Tilt's way necessarily here. In their case, they have the main interaction method (config file) in the navbar (which you suggest at #6484). For us, the API should be something less discoverable, hence doesn't need that disambiguation IMO. |
The side-bar and pages titled
Skaffold API
can get confused with theskaffold.yaml API
. We should consider explicitly renaming all occurrences ofSkaffold API
toSkaffold gRPC and HTTP service
or something similar.Also change the links from
<link>/../api
to<link>/../server
or<link>/../service
https://skaffold.dev/docs/design/api/
https://skaffold.dev/docs/references/api/
The text was updated successfully, but these errors were encountered: