Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: dev.md improvements #6503

Merged
merged 1 commit into from Aug 25, 2021
Merged

docs: dev.md improvements #6503

merged 1 commit into from Aug 25, 2021

Conversation

ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Aug 24, 2021

  • added note about the API (relevant to <1% users)
  • attempt to clarify what notify means by replacing it

- added note about the API (relevant to <1% users)
- attempt to clarify what `notify` means by replacing it

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #6503 (5599395) into main (a99ffc5) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6503      +/-   ##
==========================================
+ Coverage   70.27%   70.30%   +0.03%     
==========================================
  Files         510      512       +2     
  Lines       22988    23031      +43     
==========================================
+ Hits        16154    16192      +38     
- Misses       5776     5781       +5     
  Partials     1058     1058              
Impacted Files Coverage Δ
pkg/skaffold/log/stream/stream.go 71.42% <0.00%> (-14.29%) ⬇️
pkg/skaffold/test/test_factory.go 76.19% <0.00%> (-1.09%) ⬇️
pkg/skaffold/hooks/deploy.go 85.71% <0.00%> (ø)
pkg/skaffold/runner/v1/test.go 100.00% <0.00%> (ø)
pkg/skaffold/hooks/types.go 75.00% <0.00%> (ø)
pkg/skaffold/deploy/helm/deploy.go 77.91% <0.00%> (+1.09%) ⬆️
pkg/skaffold/deploy/kustomize/kustomize.go 74.51% <0.00%> (+1.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a99ffc5...5599395. Read the comment docs.

@tejal29 tejal29 merged commit d3839f4 into GoogleContainerTools:main Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants