Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize port forwarding #969

Closed
balopat opened this issue Sep 11, 2018 · 5 comments · Fixed by #1474
Closed

Stabilize port forwarding #969

balopat opened this issue Sep 11, 2018 · 5 comments · Fixed by #1474
Labels
area/portforward priority/p0 Highest priority. We are actively looking at delivering it.
Milestone
1.0.0

Comments

@balopat
Copy link
Contributor

balopat commented Sep 11, 2018 •
edited

We introduced port-forwarding for simple cases in #945.
This is an epic for all port-forwarding related issues that we want to solve in 1.0.0.
@balopat balopat mentioned this issue Sep 11, 2018
Merged
@r2d4 r2d4 mentioned this issue Sep 13, 2018
Closed
@harrisjoseph harrisjoseph mentioned this issue Nov 7, 2018
Closed
@dgageot
Copy link
Contributor

dgageot commented Nov 15, 2018

One easy way to shoot oneself in the foot is to run skaffold run both on Docker Desktop and on GKE.

Ports used by the local deployment will prevent the remote deployment to be forwarded locally. I don’t think there was any error message in the console and if there were, they need to be way more visible. This is not easy since error messages are hidden by application logs.

@dgageot dgageot added the kind/bug Something isn't working label Nov 15, 2018
@matti
Copy link
Contributor

matti commented Nov 21, 2018

another usecase where this fails: statefulset

@priyawadhwa priyawadhwa added priority/p2 May take a couple of releases Epic labels Nov 27, 2018
@haf
Copy link

haf commented Jan 14, 2019

This is still seemingly failing for statefulset.

@priyawadhwa priyawadhwa mentioned this issue Jan 15, 2019
Merged
@balopat balopat reopened this Jan 25, 2019
@balopat balopat added this to the 1.0.0 milestone Jan 29, 2019
@balopat balopat changed the title Handle port collisions in port-forwarding Stabilize port forwarding Mar 13, 2019
@balopat balopat added Q2-OKR priority/p0 Highest priority. We are actively looking at delivering it. and removed priority/p2 May take a couple of releases labels Apr 8, 2019
@priyawadhwa
Copy link
Contributor

priyawadhwa commented May 13, 2019 •
edited by balopat

Plan for stabilizing port forwarding

As discussed with the team, the plan is as follows:

  • Turn port forwarding off by default
  • Refactor current port forwarding code such that:
  1. Temporary services are created for forwarded pods
  2. Those services are forwarded to the local host
    for skaffold debug.
  3. Remove port forwarding for pods from skaffold dev.
  • Add logic to forward existing services automatically for skaffold dev and skaffold debug
  • Add support for user defined port forwarding via kubectl expose

priyawadhwa pushed a commit to priyawadhwa/skaffold-1 that referenced this issue May 13, 2019
Turn port forwarding off by default
b358e23 
This PR turns port forwarding off by default and updates associated
docs. Port forwarding should stay off by default at least until it is
stabilized as described in GoogleContainerTools#969.
@priyawadhwa priyawadhwa mentioned this issue May 13, 2019
Merged
@balopat
Copy link
Contributor Author

balopat commented Jul 1, 2019

We can close this epic now! Great job @priyawadhwa!

@balopat balopat closed this as completed Jul 1, 2019
@balopat balopat removed the kind/bug Something isn't working label Jul 1, 2019
@briandealwis briandealwis mentioned this issue Sep 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/portforward priority/p0 Highest priority. We are actively looking at delivering it.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Refactor port forwarding priyawadhwa/skaffold-1
5 participants
@matti @dgageot @haf @balopat @priyawadhwa