Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling for completion command #1206

Merged

Conversation

varunkashyap
Copy link
Contributor

We currently only support bash completion scripts, however as raised as part (1) of #1012 this means we output bash completion script irrespective of what the user types as the shell.

This PR makes typing bash explicit and mandatory, introduces valid args and checks for length and presence of valid args

We currently only support bash completion scripts, however as
raised as part 1 of GoogleContainerTools#1012 this means we output bash completion
script irrespective what the user types as the shell.

This PR makes bash explicit, introduces valid args and checks for
length and presence of valid args
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@varunkashyap
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@codecov-io
Copy link

Codecov Report

Merging #1206 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1206      +/-   ##
==========================================
- Coverage   41.45%   41.41%   -0.04%     
==========================================
  Files          95       95              
  Lines        4229     4233       +4     
==========================================
  Hits         1753     1753              
- Misses       2305     2309       +4     
  Partials      171      171
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ca1732...d9b1441. Read the comment docs.

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Oct 26, 2018
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 26, 2018
@balopat balopat merged commit 5d3c868 into GoogleContainerTools:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants