Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hugo and git to webhook image #1226

Merged
merged 2 commits into from Oct 30, 2018

Conversation

priyawadhwa
Copy link
Contributor

Adding hugo and git to the skaffold image will allow the webhook to
deploy it and:

  1. Use git to clone a user's branch with docs changes
  2. Use hugo to set up a static website which will show those changes

Adding hugo and git to the skaffold image will allow the webhook to
deploy it and:

1. Use git to clone a user's branch with docs changes
2. Use hugo to set up a static website which will show those changes
@r2d4
Copy link
Contributor

r2d4 commented Oct 30, 2018

@priyawadhwa
Copy link
Contributor Author

It could go there as well! Basically we just need an image for the docs controller to deploy which has git and hugo, but I think the skaffold image makes sense because hugo is needed there for #1060 as well

@codecov-io
Copy link

codecov-io commented Oct 30, 2018

Codecov Report

Merging #1226 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1226   +/-   ##
=======================================
  Coverage   41.49%   41.49%           
=======================================
  Files          95       95           
  Lines        4234     4234           
=======================================
  Hits         1757     1757           
  Misses       2307     2307           
  Partials      170      170

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16e87c5...9f174ed. Read the comment docs.

@r2d4
Copy link
Contributor

r2d4 commented Oct 30, 2018

The skaffold image shouldn't have hugo. It's made to be minimal and only have the dependencies for skaffold

@priyawadhwa priyawadhwa changed the title Add hugo and git to skaffold image Add hugo and git to webhook image Oct 30, 2018
@priyawadhwa
Copy link
Contributor Author

For sure, moved to the webhook image

@priyawadhwa priyawadhwa merged commit 232ab06 into GoogleContainerTools:master Oct 30, 2018
@priyawadhwa priyawadhwa deleted the webhook branch October 30, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants