Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not print the manifest on to stdout when doing a deploy by kustomize #1234

Conversation

RaviTezu
Copy link
Contributor

@RaviTezu RaviTezu commented Nov 5, 2018

Fixes #1231

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@codecov-io
Copy link

codecov-io commented Nov 5, 2018

Codecov Report

Merging #1234 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1234      +/-   ##
==========================================
+ Coverage   41.45%   41.47%   +0.01%     
==========================================
  Files          96       96              
  Lines        4238     4236       -2     
==========================================
  Hits         1757     1757              
+ Misses       2310     2308       -2     
  Partials      171      171
Impacted Files Coverage Δ
pkg/skaffold/deploy/kustomize.go 35.71% <ø> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23693e8...e1487c7. Read the comment docs.

@RaviTezu RaviTezu force-pushed the do_not_print_manifest_when_deploy branch from 348cae8 to e1487c7 Compare November 5, 2018 09:15
@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@dgageot dgageot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgageot dgageot merged commit 56fb997 into GoogleContainerTools:master Nov 6, 2018
@RaviTezu RaviTezu deleted the do_not_print_manifest_when_deploy branch November 6, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants