Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't lose test configuration when running skaffold fix #1251

Merged
merged 2 commits into from Nov 8, 2018

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Nov 7, 2018

Fixes #1246

@codecov-io
Copy link

codecov-io commented Nov 7, 2018

Codecov Report

Merging #1251 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1251      +/-   ##
==========================================
+ Coverage   42.28%   42.42%   +0.14%     
==========================================
  Files          96       96              
  Lines        4247     4247              
==========================================
+ Hits         1796     1802       +6     
+ Misses       2278     2269       -9     
- Partials      173      176       +3
Impacted Files Coverage Δ
pkg/skaffold/runner/runner.go 48.8% <100%> (ø) ⬆️
pkg/skaffold/schema/profiles.go 92.53% <100%> (ø) ⬆️
cmd/skaffold/app/cmd/fix.go 19.35% <0%> (+19.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b645a36...ab89819. Read the comment docs.

Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! could you also add this to the skaffold fix integration test?

Copy link
Contributor

@dgageot dgageot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be even better with a few unit tests

@nkubala nkubala merged commit 2dbbdce into GoogleContainerTools:master Nov 8, 2018
@nkubala nkubala deleted the skaffold_fix_tests branch November 8, 2018 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants