Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless command line flag #1292

Merged
merged 1 commit into from Nov 19, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Nov 19, 2018

This is yet another piece of #1204 that I'm breaking into pieces to make it easier to rebase and review.

This PR removes a command line flag that doesn't make sense

Signed-off-by: David Gageot david@gageot.net

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

codecov-io commented Nov 19, 2018

Codecov Report

Merging #1292 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1292      +/-   ##
==========================================
+ Coverage   44.24%   44.28%   +0.03%     
==========================================
  Files         104      104              
  Lines        4629     4625       -4     
==========================================
  Hits         2048     2048              
+ Misses       2372     2368       -4     
  Partials      209      209
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d808c...6cf407e. Read the comment docs.

@nkubala nkubala merged commit 769f4b2 into GoogleContainerTools:master Nov 19, 2018
@dgageot dgageot deleted the improve-runner-part02 branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants