Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release latest version of docs controller image #1293

Merged
merged 1 commit into from Nov 19, 2018

Conversation

priyawadhwa
Copy link
Contributor

PR #1288 pinned the deployment image to gcr.io/k8s-skaffold/docs-controller:latest, but that image hasn't been updated in a long time. This change will release the latest image each time a change is made, which should fix one bug in the webhook.

PR GoogleContainerTools#1288 pinned the deployment image to gcr.io/k8s-skaffold/docs-controller:latest, but that image hasn't been updated in a long time. This change will release the latest image each time a change is made, which should fix one bug in the webhook.
@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Nov 19, 2018
@codecov-io
Copy link

codecov-io commented Nov 19, 2018

Codecov Report

Merging #1293 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1293   +/-   ##
=======================================
  Coverage   44.24%   44.24%           
=======================================
  Files         104      104           
  Lines        4629     4629           
=======================================
  Hits         2048     2048           
  Misses       2372     2372           
  Partials      209      209

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d808c...8ba5b14. Read the comment docs.

@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Nov 19, 2018
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priyawadhwa priyawadhwa merged commit 4de4a32 into GoogleContainerTools:master Nov 19, 2018
@priyawadhwa priyawadhwa deleted the webhook branch November 19, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants