Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler Runner #1304

Merged
merged 2 commits into from Nov 21, 2018
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Nov 21, 2018

Another extract of #1204

  • Simplify the code that unmutes logs
  • Fix logrus usage

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

codecov-io commented Nov 21, 2018

Codecov Report

Merging #1304 into master will decrease coverage by 0.02%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1304      +/-   ##
==========================================
- Coverage   44.54%   44.51%   -0.03%     
==========================================
  Files         103      103              
  Lines        4598     4596       -2     
==========================================
- Hits         2048     2046       -2     
  Misses       2343     2343              
  Partials      207      207
Impacted Files Coverage Δ
pkg/skaffold/runner/runner.go 48.17% <42.85%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2301db6...8e53167. Read the comment docs.

@dgageot dgageot merged commit e43c479 into GoogleContainerTools:master Nov 21, 2018
@dgageot dgageot deleted the simpler-runner-light branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants