Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display usage tips to the user #1361

Merged
merged 1 commit into from Dec 4, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Dec 4, 2018

Fixes #1274

Signed-off-by: David Gageot david@gageot.net

Fixes GoogleContainerTools#1274

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

Codecov Report

Merging #1361 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1361      +/-   ##
==========================================
- Coverage   45.01%   44.98%   -0.03%     
==========================================
  Files         114      114              
  Lines        4914     4917       +3     
==========================================
  Hits         2212     2212              
- Misses       2477     2480       +3     
  Partials      225      225
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/run.go 0% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/init.go 15.34% <0%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ea582...1f53aca. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1361 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1361      +/-   ##
==========================================
- Coverage   45.01%   44.98%   -0.03%     
==========================================
  Files         114      114              
  Lines        4914     4917       +3     
==========================================
  Hits         2212     2212              
- Misses       2477     2480       +3     
  Partials      225      225
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/run.go 0% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/init.go 15.34% <0%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ea582...1f53aca. Read the comment docs.

@dgageot dgageot merged commit a1127db into GoogleContainerTools:master Dec 4, 2018
@dgageot dgageot deleted the fix-1274 branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants