Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag image by digest #1367

Merged
merged 1 commit into from Dec 7, 2018
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Dec 6, 2018

Reference images by digest when we tag them. This is more exact and prepares work on how builders tag images.

Signed-off-by: David Gageot david@gageot.net

@codecov-io
Copy link

codecov-io commented Dec 6, 2018

Codecov Report

Merging #1367 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1367   +/-   ##
=======================================
  Coverage   44.91%   44.91%           
=======================================
  Files         114      114           
  Lines        4925     4925           
=======================================
  Hits         2212     2212           
  Misses       2486     2486           
  Partials      227      227
Impacted Files Coverage Δ
pkg/skaffold/build/local/local.go 51.78% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54473e...2d69e2c. Read the comment docs.

@dgageot dgageot force-pushed the tag-from-digest branch 2 times, most recently from 8ef74ea to cbbf3c1 Compare December 7, 2018 09:49
Signed-off-by: David Gageot <david@gageot.net>
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a nit for a bit better understandability

pkg/skaffold/build/local/local.go Show resolved Hide resolved
@dgageot dgageot merged commit 4043cea into GoogleContainerTools:master Dec 7, 2018
@dgageot dgageot deleted the tag-from-digest branch December 28, 2018 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants