Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag image by digest #1367

Merged
merged 1 commit into from Dec 7, 2018
Merged

Conversation

@dgageot
Copy link
Member

dgageot commented Dec 6, 2018

Reference images by digest when we tag them. This is more exact and prepares work on how builders tag images.

Signed-off-by: David Gageot david@gageot.net

@dgageot dgageot requested review from balopat, nkubala and r2d4 as code owners Dec 6, 2018
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 6, 2018

Codecov Report

Merging #1367 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1367   +/-   ##
=======================================
  Coverage   44.91%   44.91%           
=======================================
  Files         114      114           
  Lines        4925     4925           
=======================================
  Hits         2212     2212           
  Misses       2486     2486           
  Partials      227      227
Impacted Files Coverage Δ
pkg/skaffold/build/local/local.go 51.78% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54473e...2d69e2c. Read the comment docs.

@dgageot dgageot force-pushed the dgageot:tag-from-digest branch 2 times, most recently from 8ef74ea to cbbf3c1 Dec 7, 2018
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the dgageot:tag-from-digest branch from cbbf3c1 to 2d69e2c Dec 7, 2018
Copy link
Collaborator

balopat left a comment

a nit for a bit better understandability

pkg/skaffold/build/local/local.go Show resolved Hide resolved
@balopat
balopat approved these changes Dec 7, 2018
@dgageot dgageot merged commit 4043cea into GoogleContainerTools:master Dec 7, 2018
4 checks passed
4 checks passed
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro CI build successful.
Details
@dgageot dgageot deleted the dgageot:tag-from-digest branch Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.