Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve schema upgrade tests #1383

Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Dec 11, 2018

  • Remove some duplication
  • Add more assertions on the versions actually tested

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

Codecov Report

Merging #1383 into master will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1383      +/-   ##
==========================================
+ Coverage    44.4%   44.67%   +0.26%     
==========================================
  Files         109      109              
  Lines        4542     4542              
==========================================
+ Hits         2017     2029      +12     
+ Misses       2319     2307      -12     
  Partials      206      206
Impacted Files Coverage Δ
pkg/skaffold/schema/v1alpha5/config.go 100% <0%> (+50%) ⬆️
pkg/skaffold/schema/v1alpha1/config.go 100% <0%> (+50%) ⬆️
pkg/skaffold/schema/v1beta1/config.go 100% <0%> (+50%) ⬆️
pkg/skaffold/schema/v1alpha4/config.go 100% <0%> (+50%) ⬆️
pkg/skaffold/schema/v1alpha3/config.go 100% <0%> (+50%) ⬆️
pkg/skaffold/schema/v1alpha2/config.go 100% <0%> (+50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19097cf...383d60a. Read the comment docs.

@priyawadhwa priyawadhwa merged commit dd8ffa4 into GoogleContainerTools:master Dec 12, 2018
@dgageot dgageot deleted the improve-schema-upgrade-tests branch December 28, 2018 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants