Create directory before kubectl cp #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR should fix a bug, where syncing files into new directories wasn't working because those directories didn't exist. This change will create the directory in the container via kubectl exec. This change also requires that the container has 'mkdir' in it, but I couldn't think of a better way to get around this. Also adds an integration test for file sync.
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1390 +/- ##
==========================================
+ Coverage 44.68% 44.69% +0.01%
==========================================
Files 109 109
Lines 4545 4546 +1
==========================================
+ Hits 2031 2032 +1
Misses 2308 2308
Partials 206 206
Continue to review full report at Codecov.
|
since the lag from "skaffold dev" can take a few seconds.
r2d4
reviewed
Dec 14, 2018
Save synced dirs in memory so that `kubectl exec` is only called when a new directory may need to be created in the container.
nkubala
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix a bug where syncing files into new directories wasn't working because those directories didn't exist. This change will create the directory in the container via kubectl exec. This change also requires that the container has 'mkdir' in it, but I couldn't think of a better way to get around this.
Also adds an integration test for file sync.
fix #1365