Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve port-forwarding #1452

Merged
merged 2 commits into from Jan 14, 2019
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 11, 2019

Fixes #1360

@codecov-io
Copy link

codecov-io commented Jan 11, 2019

Codecov Report

Merging #1452 into master will increase coverage by 0.12%.
The diff coverage is 44.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1452      +/-   ##
==========================================
+ Coverage   44.33%   44.46%   +0.12%     
==========================================
  Files         113      112       -1     
  Lines        4660     4642      -18     
==========================================
- Hits         2066     2064       -2     
+ Misses       2386     2371      -15     
+ Partials      208      207       -1
Impacted Files Coverage Δ
pkg/skaffold/runner/dev.go 56.52% <100%> (+3.58%) ⬆️
pkg/skaffold/kubernetes/port_forward.go 40.96% <38.46%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 967c35d...cb3fb76. Read the comment docs.

@dgageot dgageot force-pushed the fix-1360 branch 2 times, most recently from 2e3f450 to aa57d09 Compare January 12, 2019 06:58
Fix GoogleContainerTools#1360

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot merged commit 6972c5f into GoogleContainerTools:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants