New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use configured namespace for pod watcher. #1473
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Codecov Report
@@ Coverage Diff @@
## master #1473 +/- ##
==========================================
+ Coverage 45.62% 45.91% +0.29%
==========================================
Files 116 118 +2
Lines 4870 4937 +67
==========================================
+ Hits 2222 2267 +45
- Misses 2424 2440 +16
- Partials 224 230 +6
Continue to review full report at Codecov.
|
I signed it! |
CLAs look good, thanks! |
Skaffold can deploy namespaced objects as well - I think to be really correct you'd need to get the namespace (if specified) of the deployed resources as well as the default, or passed-through namespace. But this makes sense as a first step |
@r2d4 Yes absolutely. I'll quote from #1521:
|
hey @michaelfig, thanks for the contribution. agree with @r2d4 that this is a fine first step, and thanks for the explanation. looks like this broke some of the sync tests though, can you check out the failures? |
@nkubala, will do (probably next week), likely caused by one of the above known deficiencies. |
eb9a5ed
to
2be0cda
Compare
This version now honours the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for adding this feature!
@r2d4 Failed kokoro, but I can't see the logs (Google corp only). |
@michaelfig the logs should be publicly accessible. The page takes a second to load, but you should be able to click through |
@r2d4 Thanks, I was able to see the failure (in syncer), and fixed it so that it works in my own cluster. kokoro should run successfully next time. |
@michaelfig thanks for seeing this one through! |
This is a first step towards working on my on-premises cluster.
Basically, the pod watcher was failing because it requests cluster-wide pod access, but my RBAC for the current user restricts it to just the
michael
namespace.An enhancement would be to use the value of the
--namespace
flag to override the context's namespace if supplied.