Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onbuild analysis #1491

Merged
merged 2 commits into from Jan 22, 2019
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 19, 2019

Current code fails to retrieve remote image for python:3-slim

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

codecov-io commented Jan 19, 2019

Codecov Report

Merging #1491 into master will increase coverage by 0.16%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1491      +/-   ##
==========================================
+ Coverage   44.87%   45.04%   +0.16%     
==========================================
  Files         115      115              
  Lines        4771     4771              
==========================================
+ Hits         2141     2149       +8     
+ Misses       2409     2397      -12     
- Partials      221      225       +4
Impacted Files Coverage Δ
pkg/skaffold/docker/parse.go 74.88% <100%> (ø) ⬆️
pkg/skaffold/docker/remote.go 24.24% <50%> (+24.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51bcca6...9f4e83e. Read the comment docs.

@dgageot dgageot force-pushed the fix-onbuild-analysis branch 2 times, most recently from 713309c to dccc636 Compare January 20, 2019 15:37
Fixes GoogleContainerTools#1496

Signed-off-by: David Gageot <david@gageot.net>
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, there it is....I said I would take responsibility if this broke something, so let it be known that this one is all my fault 🤦‍♂️

@dgageot thanks for fixing, though I'm still a bit unsure this is the right way to do this. We can address in another PR, but I think we might want to try using latest if we don't have an explicit tag. Otherwise this can return strange results w.r.t. the image registry (e.g. sometimes it will give you back index.docker.io in places you don't want it). I'll need to play around with it some more though, so for now this LGTM

@nkubala nkubala merged commit 7c7bf71 into GoogleContainerTools:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants