Better support for docker build with a target #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1497 +/- ##
==========================================
+ Coverage 45.18% 45.45% +0.27%
==========================================
Files 115 115
Lines 4794 4818 +24
==========================================
+ Hits 2166 2190 +24
Misses 2403 2403
Partials 225 225
Continue to review full report at Codecov.
|
dgageot
force-pushed
the
fix-1120
branch
3 times, most recently
from
bcf9d89
to
7765b0a
Compare
Fix GoogleContainerTools#1120 Signed-off-by: David Gageot <david@gageot.net>
nkubala
approved these changes
Jan 25, 2019
| return nodes, nil | ||
| } | ||
|
|
||
| byTarget := make(map[string][]*parser.Node) |
There was a problem hiding this comment.
var byTarget map[string][]*parser.Node
There was a problem hiding this comment.
I don't think so. Setting a value on a nil map fails hard
|
|
||
| for _, node := range nodesByTarget[target] { | ||
| if node.Value == command.From { | ||
| inst := fromInstruction(node) |
There was a problem hiding this comment.
you could inline this into the append(...) call instead of creating a new var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1120
Signed-off-by: David Gageot david@gageot.net