Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #1439 from ltouati/fsnotify" #1508

Merged
merged 1 commit into from Jan 22, 2019

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Jan 22, 2019

This reverts commit 3402a94, reversing
changes made to 3795677.

@ltouati unfortunately, this change requires cgo, which is incompatible with cross-compilation in Golang, effectively breaking our CI. This will need to be reworked to remove its dependency on cgo before it can go back in.

…otify"

This reverts commit 3402a94, reversing
changes made to 3795677.
@dgageot
Copy link
Contributor

dgageot commented Jan 22, 2019

There no way to remove the dependency on cgo. Let’s try to improve our release system for next release

@codecov-io
Copy link

codecov-io commented Jan 22, 2019

Codecov Report

Merging #1508 into master will increase coverage by 0.27%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1508      +/-   ##
==========================================
+ Coverage      45%   45.27%   +0.27%     
==========================================
  Files         115      115              
  Lines        4802     4764      -38     
==========================================
- Hits         2161     2157       -4     
+ Misses       2420     2387      -33     
+ Partials      221      220       -1
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/dev.go 0% <0%> (ø) ⬆️
pkg/skaffold/watch/watch.go 86.04% <100%> (+3.43%) ⬆️
pkg/skaffold/watch/triggers.go 33.33% <66.66%> (+12.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d452ca...03605a2. Read the comment docs.

@nkubala nkubala merged commit 037b39a into GoogleContainerTools:master Jan 22, 2019
@nkubala nkubala deleted the revert_fsnotify branch January 22, 2019 19:03
@ltouati
Copy link
Contributor

ltouati commented Jan 24, 2019

I'm happy to work on this as Skaffold is not usable with large projects if you don't use notifications. Can you please point me to the relevant part ?

Thx

@nkubala
Copy link
Contributor Author

nkubala commented Jan 24, 2019

@ltouati thanks. unfortunately I think the responsibility lies with us, we need to come up with another CI solution that is able to build for all platforms because right now we rely on go cross compilation and this won't work with cgo. I'd like to see this go back in for the next release though, so we'll keep you posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants