Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in Getting Started #1523

Merged

Conversation

czhc
Copy link
Contributor

@czhc czhc commented Jan 24, 2019

Links in https://skaffold.dev/docs/getting-started/ are 404. Fixed with new links

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@codecov-io
Copy link

Codecov Report

Merging #1523 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1523   +/-   ##
=======================================
  Coverage   45.18%   45.18%           
=======================================
  Files         115      115           
  Lines        4791     4791           
=======================================
  Hits         2165     2165           
  Misses       2401     2401           
  Partials      225      225

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2861b72...c25e081. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jan 24, 2019

Codecov Report

Merging #1523 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1523   +/-   ##
=======================================
  Coverage   45.18%   45.18%           
=======================================
  Files         115      115           
  Lines        4791     4791           
=======================================
  Hits         2165     2165           
  Misses       2401     2401           
  Partials      225      225

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2861b72...c25e081. Read the comment docs.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good - please sign the CLA!

@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Jan 24, 2019
@czhc
Copy link
Contributor Author

czhc commented Jan 25, 2019

@balopat I signed it! :)

@googlebot
Copy link

CLAs look good, thanks!

@container-tools-bot
Copy link

Please visit http://35.236.49.252:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jan 25, 2019
@dgageot dgageot merged commit 2a4b107 into GoogleContainerTools:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants