Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix master branch #1569

Merged
merged 1 commit into from Jan 31, 2019
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 31, 2019

Master branch was broken by a PR based on an outdated version but without conflict

Signed-off-by: David Gageot david@gageot.net

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

Codecov Report

Merging #1569 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1569      +/-   ##
==========================================
+ Coverage   45.89%   46.18%   +0.28%     
==========================================
  Files         118      118              
  Lines        4961     4961              
==========================================
+ Hits         2277     2291      +14     
+ Misses       2453     2439      -14     
  Partials      231      231
Impacted Files Coverage Δ
pkg/skaffold/watch/triggers.go 63.04% <100%> (+30.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b138e5...4a6bec4. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1569 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1569      +/-   ##
==========================================
+ Coverage   45.89%   46.18%   +0.28%     
==========================================
  Files         118      118              
  Lines        4961     4961              
==========================================
+ Hits         2277     2291      +14     
+ Misses       2453     2439      -14     
  Partials      231      231
Impacted Files Coverage Δ
pkg/skaffold/watch/triggers.go 63.04% <100%> (+30.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b138e5...4a6bec4. Read the comment docs.

@dgageot
Copy link
Contributor Author

dgageot commented Jan 31, 2019

Let's merge this one since the master branch is broken otherwise

@dgageot dgageot merged commit b62bfbb into GoogleContainerTools:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants