Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore cache-from pull errors #1604

Merged

Conversation

Projects
None yet
4 participants
@dgageot
Copy link
Member

commented Feb 5, 2019

Fix #1592

@dgageot dgageot requested review from balopat, nkubala, priyawadhwa and r2d4 as code owners Feb 5, 2019

@googlebot googlebot added the cla: yes label Feb 5, 2019

@dgageot dgageot changed the title Ignore cache from errors Ignore cache-from pull errors Feb 5, 2019

dgageot added some commits Feb 5, 2019

Extract the code that prints warnings
Signed-off-by: David Gageot <david@gageot.net>
Ignore cache-from images pull errors
Fix #1592

Signed-off-by: David Gageot <david@gageot.net>

@dgageot dgageot force-pushed the dgageot:ignore-cache-from-errors branch from 8f56f48 to db0f5ee Feb 5, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Feb 5, 2019

Codecov Report

Merging #1604 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1604      +/-   ##
==========================================
+ Coverage   46.88%   46.93%   +0.04%     
==========================================
  Files         118      117       -1     
  Lines        5042     5039       -3     
==========================================
+ Hits         2364     2365       +1     
+ Misses       2446     2442       -4     
  Partials      232      232
Impacted Files Coverage Δ
pkg/skaffold/build/local/docker.go 57.5% <100%> (ø) ⬆️
pkg/skaffold/build/tag/env_template.go 82.75% <100%> (+5.33%) ⬆️
pkg/skaffold/build/gcb/docker.go 100% <100%> (ø) ⬆️
pkg/skaffold/deploy/kubectl/images.go 97.91% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8efe309...db0f5ee. Read the comment docs.

@balopat

balopat approved these changes Feb 5, 2019

@balopat balopat merged commit 9728faa into GoogleContainerTools:master Feb 5, 2019

4 checks passed

cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro CI build successful.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.