Fix sub directory support with Kaniko and GCB #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
dgageot
force-pushed
the
fix-sub-folder
branch
from
984290d
to
a060471
Compare
Codecov Report
@@ Coverage Diff @@
## master #1613 +/- ##
==========================================
+ Coverage 46.31% 46.33% +0.01%
==========================================
Files 117 117
Lines 5106 5111 +5
==========================================
+ Hits 2365 2368 +3
- Misses 2508 2509 +1
- Partials 233 234 +1
Continue to review full report at Codecov.
|
dgageot
force-pushed
the
fix-sub-folder
branch
2 times, most recently
from
6b42c90
to
390d46f
Compare
Fix GoogleContainerTools#1611 Fix GoogleContainerTools#1612 Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
fix-sub-folder
branch
from
390d46f
to
af1db5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for artifacts that are built with Kaniko or GCB and whose sources are not in
.directory is currently broken.This PR fixes that and adds a unit test and two integration tests to make sure this stays fixed!
Fixes #1611
Fixes #1612
This regression was introduced by #1477