Fix regression from port forwarding #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I introduced this regression when adding "pod name" to they port forward entry key -- whenever a pod was replaced, it's name would change and it would be mapped to a new port. This should fix that issue, but I initally introduced "pod name" so that replicated pods would map to different ports. I'll work on finding a solution for that in another PR.
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
r2d4
as code owners
priyawadhwa
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1616 +/- ##
=======================================
Coverage 47.01% 47.01%
=======================================
Files 117 117
Lines 5118 5118
=======================================
Hits 2406 2406
Misses 2471 2471
Partials 241 241
Continue to review full report at Codecov.
|
dgageot
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced this regression when adding "pod name" to they port forward
entry key -- whenever a pod was replaced, it's name would change and it
would be mapped to a new port.
This should fix that issue, but I initally introduced "pod name" so that
replicated pods would map to different ports. I'll work on finding a
solution for that in another PR.
Fix #1594