Add required tags
#1642
Merged
Add required tags
#1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1642 +/- ##
==========================================
- Coverage 47.74% 47.73% -0.01%
==========================================
Files 120 120
Lines 5339 5342 +3
==========================================
+ Hits 2549 2550 +1
- Misses 2533 2534 +1
- Partials 257 258 +1
Continue to review full report at Codecov.
|
|
@balopat @priyawadhwa @nkubala The PR is failing on an integration test that has no artifact to build. Should we really support that usecase? |
|
Is the idea that people would use skaffold just to deploy manifests? Personally I'm not sure how useful that would be. |
dgageot
force-pushed
the
add-required
branch
from
a94750c
to
a163c66
Compare
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
add-required
branch
from
a163c66
to
344c6bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot david@gageot.net