Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comments and schema #1652

Merged
merged 2 commits into from Feb 14, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Feb 14, 2019

Signed-off-by: David Gageot david@gageot.net

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@b9c979d). Click here to learn what that means.
The diff coverage is 95.27%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1652   +/-   ##
=========================================
  Coverage          ?   48.13%           
=========================================
  Files             ?      120           
  Lines             ?     5322           
  Branches          ?        0           
=========================================
  Hits              ?     2562           
  Misses            ?     2502           
  Partials          ?      258
Impacted Files Coverage Δ
pkg/skaffold/jib/jib_gradle.go 100% <100%> (ø)
pkg/skaffold/jib/jib_maven.go 100% <100%> (ø)
schemas/main.go 87.19% <95.2%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c979d...22f3e28. Read the comment docs.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balopat balopat merged commit c4eeb66 into GoogleContainerTools:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants