New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm flags for Global, Install and Upgrade helm commands #1673
Helm flags for Global, Install and Upgrade helm commands #1673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Left some comments.
Codecov Report
@@ Coverage Diff @@
## master #1673 +/- ##
==========================================
+ Coverage 46.52% 46.55% +0.02%
==========================================
Files 125 125
Lines 5661 5664 +3
==========================================
+ Hits 2634 2637 +3
Misses 2754 2754
Partials 273 273
Continue to review full report at Codecov.
|
This is now ready to go. Thanks for the comments @priyawadhwa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more fix :)
Is this ok to go? |
@tjerkw I think you just need to rebase, and then I can merge this! |
Looks like travis failed --
If you run that command and commit I think that should fix it! |
Done. Forgot about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks so much for your contribution!
This solves the following outstanding pull requests (they can all be closed):
#1284 #1506 #1507 #1445 #1499
It allows configuring flags to helm, for
The code is similar to the code in kustomize, and kubectl. They all have the option to add flags to the deploy commands.
This also makes skaffold easier to use if helm comes with new flags, it will "just work". Since the flags are free text. Just add them, and run 👍
Btw: The flags are set on the top level "HelmDeploy" struct. Not in the "HelmRelease" section in the yaml file.
This is because a "Global" flags list doesn't make sense per release. Then its not global anymore.
Custom flags to "helm install/upgrade" do make sense per release. But most of the time you probably want to keep them similar. Thats why i didn't set the flag on the HelmRelease struct.
Also: The flags clash a bit with the "Wait" and "RecreatePods" and "Namespace" fields in HelmRelease. However if you use both helm would complain and not run. So we're fine there.