Restructure integration tests #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkubala
requested review from
balopat,
dgageot,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1678 +/- ##
=======================================
Coverage 46.69% 46.69%
=======================================
Files 123 123
Lines 5600 5600
=======================================
Hits 2615 2615
Misses 2716 2716
Partials 269 269Continue to review full report at Codecov.
|
balopat
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the integration tests up into separate files, grouped roughly by skaffold functionality tested. This is done purely for readability, as the original
run_test.gofile was getting way too big.While debugging failing tests @balopat and I realized that the
TestDevjob sometimes wasn't giving the watcher enough time to start up before changing a file and expecting a redepoy, so the test was flaking. I added atime.Sleep()of 5 seconds in the test to give it time to start running. Not my favorite fix but it should get the job done.