Fix schemas #1701
Merged
Fix schemas #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1701 +/- ##
==========================================
- Coverage 46.8% 46.61% -0.19%
==========================================
Files 126 125 -1
Lines 5935 5663 -272
==========================================
- Hits 2778 2640 -138
+ Misses 2865 2752 -113
+ Partials 292 271 -21
Continue to review full report at Codecov.
|
dgageot
added
the
docs-modifications
|
Please visit http://35.236.109.79:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
dgageot
force-pushed
the
fix-schemas
branch
2 times, most recently
from
30509cc
to
cb6c5dc
Compare
nkubala
approved these changes
Feb 28, 2019
hack/schemas/main.go
Outdated
| } | ||
|
|
||
| schema := Schema{ | ||
| Version: "http://json-schema-org/draft-07/schema#", |
| for (var key in properties.properties) { | ||
| allProperties.push([key, properties.properties[key]]); | ||
| for (var anyOf of definitions[name].anyOf) { | ||
| console.log(anyOf); |
There was a problem hiding this comment.
is this for debugging? maybe remove? probably doesn't matter too much though.
+ Make sure properties are displayed in preferred order in doc + Fix schemas to improve validation in IntelliJ and VSCode + Improve rendering in IntelliJ and VSCode Signed-off-by: David Gageot <david@gageot.net>
|
Thank you @nkubala. I've addressed the nits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested the current schemas in multiple places and this change makes them work everywhere.
Also improves the rendering of the properties map on skaffold.dev. They are now displayed in the preferred order for easier reading.
Signed-off-by: David Gageot david@gageot.net