Fix regression in sync #1722
Merged
Fix regression in sync #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In GoogleContainerTools#1709 I introduced a regression to sync by removing the "-C /" from the tar extraction, which forced all files to be extracted at root. We actually still want this, since now that we append the workdir for relative paths all paths in the tarball are absolute paths and so should be extracted at root. This should fix GoogleContainerTools#1721.
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
r2d4
as code owners
dgageot
approved these changes
Mar 5, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1709 I introduced a regression to sync by removing the "-C /" from
the tar extraction, which forced all files to be extracted at root. We
actually still want this, since now that we append the workdir for relative paths all paths in the
tarball are absolute paths and so should be extracted at root.
This should fix #1721.