Improve skaffold init performance by not walking hidden dirs.
#1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`skaffold init` should skip walking hidden directories like .git, IDE config dirs like .vscode, .idea etc. For a small github project with .git dir of 44K, the time improvement was 1.3 ms or roughly 86% Please see gist https://gist.github.com/tejal29/96958f32ea88cecd6cbe5edd26c68968
tejal29
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
balopat
approved these changes
Mar 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #1724 +/- ##
==========================================
+ Coverage 46.91% 46.93% +0.02%
==========================================
Files 126 126
Lines 6167 6176 +9
==========================================
+ Hits 2893 2899 +6
- Misses 2976 2979 +3
Partials 298 298
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skaffold initshould skip walking hidden directories like .git,IDE config dirs like .vscode, .idea etc.
For a small github project with .git dir of 44K, the time improvement
was 1.3 ms or roughly 86%
Please see gist https://gist.github.com/tejal29/96958f32ea88cecd6cbe5edd26c68968