Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve `skaffold init` performance by not walking hidden dirs. #1724

Merged
merged 1 commit into from Mar 5, 2019

Conversation

Projects
None yet
4 participants
@tejal29
Copy link
Member

commented Mar 4, 2019

skaffold init should skip walking hidden directories like .git,
IDE config dirs like .vscode, .idea etc.

For a small github project with .git dir of 44K, the time improvement
was 1.3 ms or roughly 86%

Please see gist https://gist.github.com/tejal29/96958f32ea88cecd6cbe5edd26c68968

Improve `skaffold init` performance by walking fewer dirs.
`skaffold init` should skip walking hidden directories like .git,
IDE config dirs like .vscode, .idea etc.

For a small github project with .git dir of 44K, the time improvement
was 1.3 ms or roughly 86%

Please see gist https://gist.github.com/tejal29/96958f32ea88cecd6cbe5edd26c68968
@balopat

balopat approved these changes Mar 4, 2019

Copy link
Collaborator

left a comment

Awesome, thank you!
LGTM

@codecov-io

This comment has been minimized.

Copy link

commented Mar 4, 2019

Codecov Report

Merging #1724 into master will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1724      +/-   ##
==========================================
+ Coverage   46.91%   46.93%   +0.02%     
==========================================
  Files         126      126              
  Lines        6167     6176       +9     
==========================================
+ Hits         2893     2899       +6     
- Misses       2976     2979       +3     
  Partials      298      298
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/init.go 15.27% <0%> (-0.08%) ⬇️
pkg/skaffold/util/util.go 45.75% <75%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a829c4...104a490. Read the comment docs.

@tejal29 tejal29 merged commit 45bb7f4 into GoogleContainerTools:master Mar 5, 2019

4 checks passed

cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro CI build successful.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.