Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make initContainer in localDir type of kaniko build param #1727

Merged

Conversation

venkatk-25
Copy link
Contributor

This is to parameterize the InitContainer Image in LocalDir build of kaniko, so we can use custom one apart from busybox, especially useful in private clouds where public repos are not accessible

@codecov-io
Copy link

codecov-io commented Mar 5, 2019

Codecov Report

Merging #1727 into master will decrease coverage by 0.02%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1727      +/-   ##
==========================================
- Coverage   46.93%   46.91%   -0.03%     
==========================================
  Files         126      126              
  Lines        6176     6182       +6     
==========================================
+ Hits         2899     2900       +1     
- Misses       2979     2984       +5     
  Partials      298      298
Impacted Files Coverage Δ
pkg/skaffold/schema/defaults/defaults.go 37.66% <16.66%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45bb7f4...54d742c. Read the comment docs.

@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Mar 5, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Mar 5, 2019
@balopat balopat self-assigned this Mar 7, 2019
@balopat balopat merged commit 7f52077 into GoogleContainerTools:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants