Improve artifact caching #1741
Merged
Improve artifact caching #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First PR with some small improvements to artifact caching: 1. Include filename in the cache key generation 2. Sort dependencies to ensure the key is reproducible 3. Add unit tests for both of these additions Also, simplifly the cache hasher function
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
r2d4
as code owners
dgageot
approved these changes
Mar 6, 2019
|
Sorry @priyawadhwa, this needs to be rebased |
…o improve-caching
Codecov Report
@@ Coverage Diff @@
## master #1741 +/- ##
==========================================
+ Coverage 47.02% 47.35% +0.33%
==========================================
Files 126 126
Lines 6180 6179 -1
==========================================
+ Hits 2906 2926 +20
+ Misses 2981 2955 -26
- Partials 293 298 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some improvements to artifact caching:
Also, simplify the cache hasher function
begins to fix #1740