Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer output #1745

Merged
merged 2 commits into from Mar 7, 2019

Conversation

Projects
None yet
4 participants
@dgageot
Copy link
Member

commented Mar 6, 2019

Produce a nicer, more compact, easier to read output

@dgageot dgageot requested review from balopat, nkubala, priyawadhwa and r2d4 as code owners Mar 6, 2019

@googlebot googlebot added the cla: yes label Mar 6, 2019

@dgageot dgageot added the !! wip !! label Mar 6, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Mar 6, 2019

Codecov Report

Merging #1745 into master will increase coverage by 0.01%.
The diff coverage is 52.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1745      +/-   ##
==========================================
+ Coverage   47.35%   47.37%   +0.01%     
==========================================
  Files         126      126              
  Lines        6179     6187       +8     
==========================================
+ Hits         2926     2931       +5     
- Misses       2955     2956       +1     
- Partials      298      300       +2
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/build.go 0% <0%> (ø) ⬆️
pkg/skaffold/runner/runner.go 60.84% <100%> (+0.56%) ⬆️
pkg/skaffold/build/cache.go 53.77% <50%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75b6834...04aec19. Read the comment docs.

Make build output nicer to read
Signed-off-by: David Gageot <david@gageot.net>

@dgageot dgageot force-pushed the dgageot:nicer-output branch from 0fc8302 to 2ce0004 Mar 6, 2019

@dgageot dgageot removed the !! wip !! label Mar 6, 2019

Suppress build output that’s useful only with -q
Signed-off-by: David Gageot <david@gageot.net>

@dgageot dgageot force-pushed the dgageot:nicer-output branch from 2ce0004 to 04aec19 Mar 7, 2019

@nkubala

nkubala approved these changes Mar 7, 2019

@nkubala nkubala merged commit fc702c3 into GoogleContainerTools:master Mar 7, 2019

4 checks passed

cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro CI build successful.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.