Remove duplication integration tests #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
dgageot
force-pushed
the
remove-duplication-integration-tests
branch
from
7f47efc
to
68124b4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1760 +/- ##
==========================================
+ Coverage 47% 47.04% +0.04%
==========================================
Files 130 130
Lines 6270 6264 -6
==========================================
Hits 2947 2947
+ Misses 3021 3015 -6
Partials 302 302
Continue to review full report at Codecov.
|
nkubala
reviewed
Mar 8, 2019
There was a problem hiding this comment.
love this. integration tests failed with
helper.go:144: skaffold run: Running [skaffold run --namespace skaffoldf6bpv]: stdout , stderr: time="2019-03-08T09:28:45Z" level=fatal msg="creating runner: getting default repo: retrieving global config: resolving config file location: retrieving home directory: exec: \"getent\": executable file not found in $PATH"
but i'm not sure it's related to this change....gonna rerun and see if it fails again
dgageot
force-pushed
the
remove-duplication-integration-tests
branch
from
68124b4
to
60e278b
Compare
dgageot
force-pushed
the
remove-duplication-integration-tests
branch
5 times, most recently
from
1e0e7e3
to
86104c2
Compare
|
Let's rebase to trigger one more round of tests |
Also make sure all tests run in a namespace Fixes GoogleContainerTools#1537 Signed-off-by: David Gageot <david@gageot.net>
This makes sure we can run tests locally the same way as they run on the CI. Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
remove-duplication-integration-tests
branch
from
86104c2
to
ef51e17
Compare
|
@nkubala This was an issue with the PR. Should be all good now |
nkubala
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.