Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try newer versions of Go #1775

Merged
merged 1 commit into from Mar 12, 2019
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Mar 11, 2019

Signed-off-by: David Gageot david@gageot.net

@nkubala
Copy link
Contributor

nkubala commented Mar 11, 2019

should we update the README or contributor's guide to reflect that we require go version 1.11 or higher?

@codecov-io
Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #1775 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1775   +/-   ##
======================================
  Coverage    46.4%   46.4%           
======================================
  Files         132     132           
  Lines        6322    6322           
======================================
  Hits         2934    2934           
  Misses       3087    3087           
  Partials      301     301

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b957386...e91a22a. Read the comment docs.

@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Mar 12, 2019
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Mar 12, 2019
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Copy link
Contributor Author

dgageot commented Mar 12, 2019

@nkubala waiting for #1764 to be merged. I'll amend it with the Go version

@priyawadhwa priyawadhwa mentioned this pull request Mar 12, 2019
@dgageot dgageot merged commit 9e0d4b7 into GoogleContainerTools:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants