Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve make test #1776

Merged
merged 2 commits into from Mar 11, 2019
Merged

Improve make test #1776

merged 2 commits into from Mar 11, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Mar 11, 2019

  • Make sure test results are not cached
  • Remove packages that are not tested from the output
make test
Running go tests...
ok  	github.com/GoogleContainerTools/skaffold/cmd/skaffold/app/cmd	0.866s	coverage: 9.0% of statements
ok  	github.com/GoogleContainerTools/skaffold/cmd/skaffold/app/cmd/config	0.409s	coverage: 36.9% of statements
ok  	github.com/GoogleContainerTools/skaffold/cmd/skaffold/app/flags	0.091s	coverage: 52.2% of statements
ok  	github.com/GoogleContainerTools/skaffold/hack/schemas	0.435s	coverage: 90.6% of statements
ok  	github.com/GoogleContainerTools/skaffold/integration	0.826s	coverage: 0.0% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/apiversion	0.064s	coverage: 100.0% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/bazel	0.325s	coverage: 88.5% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/build	0.455s	coverage: 68.9% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/build/bazel	0.354s	coverage: 18.2% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/build/docker	0.373s	coverage: 16.0% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/build/kaniko	0.700s	coverage: 3.3% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/build/local	0.409s	coverage: 32.8% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/build/plugin	0.505s	coverage: 12.8% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/build/tag	1.896s	coverage: 82.8% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/color	0.342s	coverage: 82.4% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/config	0.244s	coverage: 93.8% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/deploy	0.917s	coverage: 56.2% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/deploy/kubectl	0.375s	coverage: 54.3% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/docker	3.181s	coverage: 70.3% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/gcp	0.367s	coverage: 92.0% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/jib	0.358s	coverage: 95.5% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/kubernetes	2.276s	coverage: 23.1% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/kubernetes/context	0.335s	coverage: 76.9% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/plugin/environments/gcb	0.426s	coverage: 11.7% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/runner	3.930s	coverage: 61.6% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema	0.541s	coverage: 90.9% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/defaults	0.440s	coverage: 37.5% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/v1alpha1	0.562s	coverage: 78.1% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/v1alpha2	0.358s	coverage: 75.0% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/v1alpha3	0.343s	coverage: 80.8% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/v1alpha4	0.340s	coverage: 72.7% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/v1alpha5	0.348s	coverage: 77.8% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/v1beta1	0.349s	coverage: 72.7% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/v1beta2	0.334s	coverage: 72.7% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/v1beta3	0.366s	coverage: 72.7% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/v1beta4	0.365s	coverage: 72.7% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/v1beta5	0.336s	coverage: 75.0% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/v1beta6	0.369s	coverage: 75.0% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/sync	0.448s	coverage: 77.0% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/util	0.418s	coverage: 52.4% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/version	0.228s	coverage: 71.4% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/watch	0.261s	coverage: 67.9% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/yamltags	0.068s	coverage: 92.8% of statements
ok  	github.com/GoogleContainerTools/skaffold/pkg/webhook/labels	0.197s	coverage: 100.0% of statements```

@codecov-io
Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #1776 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1776   +/-   ##
=======================================
  Coverage   47.06%   47.06%           
=======================================
  Files         130      130           
  Lines        6261     6261           
=======================================
  Hits         2947     2947           
  Misses       3012     3012           
  Partials      302      302

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c3f9d...a4b8ed4. Read the comment docs.

@nkubala
Copy link
Contributor

nkubala commented Mar 11, 2019

looks like another integration test flake, I'll restart.

also, there are almost 10000 lines of maven-related logs in the integration test logs... 😮

Progress (1): 2.4/2.7 MB
Progress (1): 2.4/2.7 MB
Progress (1): 2.4/2.7 MB
Progress (1): 2.4/2.7 MB
Progress (1): 2.4/2.7 MB
Progress (1): 2.4/2.7 MB
Progress (1): 2.4/2.7 MB
Progress (1): 2.4/2.7 MB
Progress (1): 2.4/2.7 MB
...
ad infinitum

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@nkubala nkubala merged commit a7edf9e into GoogleContainerTools:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants