Fix race in event logs #1786
Merged
Fix race in event logs #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1786 +/- ##
==========================================
- Coverage 46.71% 46.27% -0.45%
==========================================
Files 135 137 +2
Lines 6347 6492 +145
==========================================
+ Hits 2965 3004 +39
- Misses 3083 3188 +105
- Partials 299 300 +1
Continue to review full report at Codecov.
|
|
kokoro is green but didn't get the status update |
dgageot
force-pushed
the
fix-race-events
branch
from
a2f18d2
to
5ad31c2
Compare
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
And return a deep copy of the state Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
fix-race-events
branch
from
5ad31c2
to
697ab63
Compare
nkubala
approved these changes
Mar 12, 2019
|
not sure what's going on with travis, I restarted the job but it doesn't wanna queue itself for some reason 🤷♂️ |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nkubala This PR fixes three races in the eventing code.