combined output for integration tests skaffold runner #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balopat
requested review from
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
|
@balopat Can you explain why it's needed? |
|
Yes - see the current error output of the failing build #1728 |
|
Excellent. Needs go import though |
|
Yes tomorrow:) |
Codecov Report
@@ Coverage Diff @@
## master #1800 +/- ##
=======================================
Coverage 45.53% 45.53%
=======================================
Files 142 142
Lines 6626 6626
=======================================
Hits 3017 3017
Misses 3307 3307
Partials 302 302Continue to review full report at Codecov.
|
dgageot
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.