Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race conditions and run tests with a race detector #1801

Merged
merged 3 commits into from Mar 15, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Mar 15, 2019

No description provided.

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

Codecov Report

Merging #1801 into master will increase coverage by 0.02%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1801      +/-   ##
==========================================
+ Coverage   45.53%   45.55%   +0.02%     
==========================================
  Files         142      142              
  Lines        6626     6625       -1     
==========================================
+ Hits         3017     3018       +1     
+ Misses       3307     3305       -2     
  Partials      302      302
Impacted Files Coverage Δ
pkg/skaffold/build/cache/retrieve.go 89.05% <100%> (+2.72%) ⬆️
pkg/skaffold/event/event.go 32.2% <81.81%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd40af1...580494b. Read the comment docs.

@balopat balopat merged commit 5fa4ce3 into GoogleContainerTools:master Mar 15, 2019
@nkubala nkubala mentioned this pull request Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants