Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hidden flag --force-colors to always print color codes #2033

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

corneliusweig
Copy link
Contributor

Close #2021

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
@corneliusweig corneliusweig changed the title Add hidden flag to always print color codes Add hidden flag --force-colors to always print color codes Apr 26, 2019
@codecov-io
Copy link

Codecov Report

Merging #2033 into master will decrease coverage by 0.02%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2033      +/-   ##
==========================================
- Coverage   55.96%   55.94%   -0.03%     
==========================================
  Files         173      173              
  Lines        7556     7563       +7     
==========================================
+ Hits         4229     4231       +2     
- Misses       2924     2928       +4     
- Partials      403      404       +1
Impacted Files Coverage Δ
pkg/skaffold/color/formatter.go 80% <0%> (-10.91%) ⬇️
cmd/skaffold/app/cmd/cmd.go 74% <50%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6184872...1e504f2. Read the comment docs.

@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Apr 26, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 26, 2019
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@priyawadhwa priyawadhwa merged commit ce89a16 into GoogleContainerTools:master Apr 26, 2019
@corneliusweig corneliusweig deleted the force-colors branch April 26, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to always use terminal color escape sequence
5 participants