Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for the notify trigger #2227

Closed
wants to merge 3 commits into from

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jun 6, 2019

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #2227 into master will decrease coverage by 2.47%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2227      +/-   ##
==========================================
- Coverage   61.33%   58.86%   -2.48%     
==========================================
  Files         187      188       +1     
  Lines        7995     7849     -146     
==========================================
- Hits         4904     4620     -284     
- Misses       2701     2860     +159     
+ Partials      390      369      -21
Impacted Files Coverage Δ
pkg/skaffold/watch/triggers.go 63.04% <0%> (+17.39%) ⬆️
pkg/skaffold/build/cluster/types.go 0% <0%> (-55.18%) ⬇️
pkg/skaffold/kubernetes/wait.go 0% <0%> (-46.06%) ⬇️
pkg/skaffold/kubernetes/context/context.go 66.66% <0%> (-33.34%) ⬇️
pkg/skaffold/docker/image_util.go 0% <0%> (-33.34%) ⬇️
pkg/skaffold/build/local/types.go 53.12% <0%> (-14.53%) ⬇️
pkg/skaffold/runner/diagnose.go 0% <0%> (-13.05%) ⬇️
pkg/skaffold/sync/sync.go 70.32% <0%> (-11.73%) ⬇️
cmd/skaffold/man/man.go 77.27% <0%> (-10.97%) ⬇️
pkg/skaffold/docker/remote.go 53.12% <0%> (-9.38%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee24699...8a5ad98. Read the comment docs.

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot closed this Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants